fix: Update cargo's config to use the new linker parameter#100
Merged
9names merged 1 commit intorp-rs:mainfrom May 16, 2025
Merged
fix: Update cargo's config to use the new linker parameter#1009names merged 1 commit intorp-rs:mainfrom
9names merged 1 commit intorp-rs:mainfrom
Conversation
Since rust v1.74, the linker can be selected without using rustflags. This plays nicer with `RUSTFLAGS`.
9names
approved these changes
May 16, 2025
Member
9names
left a comment
9names
left a comment
There was a problem hiding this comment.
This plays nicer with RUSTFLAGS
If you have RUSTFLAGS problems you're still going to run into issues, but this is still a good change IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rust v1.74, the linker can be selected without using rustflags. This plays nicer with
RUSTFLAGS.Fixes #82